fix: DM responses appearing in separate threads for AI Assistant apps#689
Merged
Conversation
Two issues were causing DM responses to appear incorrectly: 1. For Slack AI/Assistant apps, every DM is treated as a thread. The code was not passing thread_ts when responding, causing responses to appear as separate notifications/threads instead of in the same conversation. 2. The Assistant framework receives message.im events through a separate pipeline from global middleware, causing both handleDirectMessage and handleUserMessage to fire for the same event, resulting in duplicate responses. Changes: - Add thread_ts: event.ts to chat.postMessage in handleDirectMessage - Add guard in handleUserMessage to skip DMs without thread_ts (handled by handleDirectMessage via middleware) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Two issues were causing incorrect behavior for Addie's DM responses:
Responses appearing in separate threads: For Slack AI/Assistant apps, every DM is treated as a thread. The code was not passing
thread_tswhen responding, causing responses to appear as separate notifications/threads instead of in the same conversation.Duplicate responses: The Assistant framework receives
message.imevents through a separate pipeline from global middleware, causing bothhandleDirectMessageandhandleUserMessageto fire for the same event, resulting in duplicate responses with different content.Changes
thread_ts: event.tstochat.postMessageinhandleDirectMessageto ensure responses appear in the same thread as the user's messagehandleUserMessageto skip DMs withoutthread_ts(these are handled byhandleDirectMessagevia middleware)Test plan
🤖 Generated with Claude Code