fix: handle RSS guids with missing text content#691
Merged
Conversation
Some RSS feeds (e.g., Marketing Week) return guid elements with only
XML attributes but no text content, resulting in objects like
`{"$":{"isPermaLink":"false"}}` instead of strings. This caused
"Cannot convert object to primitive value" errors.
- Update FeedItem type to reflect optional `_` (text) and `$` (attrs)
- Extract guid text content properly, falling back to link URL
- Remove per-feed debug logs to reduce log volume
- Only log RSS processing summary when there are new articles or errors
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"$":{"isPermaLink":"false"}})Changes
FeedItem.guidtype to reflect optional_(text content) and$(attributes) propertiesString()coercion ingenerateSlugfor safetyTest plan
🤖 Generated with Claude Code