fix: correct organization tier filtering logic#757
Merged
Conversation
- Remove subscription_amount > 0 check from MEMBER_FILTER to include comped members with $0 subscriptions - Fix case-sensitive email domain matching in HAS_USER and HAS_ENGAGED_USER filters (LIKE → LOWER/SPLIT_PART comparison) - Add Slack activity detection to HAS_ENGAGED_USER filter so organizations qualify as "Engaged" if they have Slack users active in the last 30 days - Update getOrgTier function to match simplified MEMBER_FILTER Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Address code review feedback: - Remove subscription_amount check from deriveOrgTier in accounts.ts to match the SQL MEMBER_FILTER (comped members are now included) - Update doc comment to clarify members include comped subscriptions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Jan 16, 2026
* fix: correct organization tier filtering logic - Remove subscription_amount > 0 check from MEMBER_FILTER to include comped members with $0 subscriptions - Fix case-sensitive email domain matching in HAS_USER and HAS_ENGAGED_USER filters (LIKE → LOWER/SPLIT_PART comparison) - Add Slack activity detection to HAS_ENGAGED_USER filter so organizations qualify as "Engaged" if they have Slack users active in the last 30 days - Update getOrgTier function to match simplified MEMBER_FILTER Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: add empty changeset Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: align deriveOrgTier with MEMBER_FILTER Address code review feedback: - Remove subscription_amount check from deriveOrgTier in accounts.ts to match the SQL MEMBER_FILTER (comped members are now included) - Update doc comment to clarify members include comped subscriptions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Jan 20, 2026
* fix: correct organization tier filtering logic - Remove subscription_amount > 0 check from MEMBER_FILTER to include comped members with $0 subscriptions - Fix case-sensitive email domain matching in HAS_USER and HAS_ENGAGED_USER filters (LIKE → LOWER/SPLIT_PART comparison) - Add Slack activity detection to HAS_ENGAGED_USER filter so organizations qualify as "Engaged" if they have Slack users active in the last 30 days - Update getOrgTier function to match simplified MEMBER_FILTER Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: add empty changeset Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: align deriveOrgTier with MEMBER_FILTER Address code review feedback: - Remove subscription_amount check from deriveOrgTier in accounts.ts to match the SQL MEMBER_FILTER (comped members are now included) - Update doc comment to clarify members include comped subscriptions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscription_amount > 0check from MEMBER_FILTER to include comped members with $0 subscriptionsLOWER(SPLIT_PART(...))instead of case-sensitiveLIKE)Test plan
🤖 Generated with Claude Code