Skip to content

fix: Add MCP protocol support to agent health checks#785

Merged
bokelley merged 1 commit into
mainfrom
bokelley/addie-agent-check
Jan 15, 2026
Merged

fix: Add MCP protocol support to agent health checks#785
bokelley merged 1 commit into
mainfrom
bokelley/addie-agent-check

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

  • Fixes Addie reporting MCP agents as "unreachable" when probing them
  • MCP agents like https://creative.adcontextprotocol.org/mcp don't serve A2A-style agent-card.json - they use MCP protocol instead
  • Addie's probe_adcp_agent now tries A2A first, then falls back to MCP protocol

Test plan

  • Type checking passes
  • All 241 unit tests pass
  • Verified fix with curl: MCP agent returns valid: true with protocol "mcp"
  • Local server tested via Docker

Bug reported by: Simon Safhalter

🤖 Generated with Claude Code

Addie's probe_adcp_agent was reporting MCP agents as "unreachable" because
validateAgentCards only checked for A2A-style agent-card.json endpoints.
MCP agents use streamable HTTP instead.

Changes:
- Refactored validateSingleAgentCard to try A2A first, then MCP as fallback
- Added 5s timeout to MCP validation using Promise.race
- Returns combined errors when both protocols fail
- Added tests for MCP protocol support

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@bokelley bokelley merged commit b409780 into main Jan 15, 2026
6 checks passed
bokelley added a commit that referenced this pull request Jan 16, 2026
Addie's probe_adcp_agent was reporting MCP agents as "unreachable" because
validateAgentCards only checked for A2A-style agent-card.json endpoints.
MCP agents use streamable HTTP instead.

Changes:
- Refactored validateSingleAgentCard to try A2A first, then MCP as fallback
- Added 5s timeout to MCP validation using Promise.race
- Returns combined errors when both protocols fail
- Added tests for MCP protocol support

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Jan 20, 2026
Addie's probe_adcp_agent was reporting MCP agents as "unreachable" because
validateAgentCards only checked for A2A-style agent-card.json endpoints.
MCP agents use streamable HTTP instead.

Changes:
- Refactored validateSingleAgentCard to try A2A first, then MCP as fallback
- Added 5s timeout to MCP validation using Promise.race
- Returns combined errors when both protocols fail
- Added tests for MCP protocol support

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant