fix: Add access control for private Slack channel search#786
Merged
Conversation
- Fix channel activity query to use slack_ts instead of created_at - Remove aao-admin from exclusion list (was blocking indexing) - Add access control for private channels based on working group membership - Filter search results to only show channels user has access to - Only index private channels that have linked working groups - Add getAccessiblePrivateChannelIds for efficient membership lookup - Add getWorkingGroupIdsByUser for local membership queries This ensures users can only see search results from: 1. Public channels (accessible to all workspace members) 2. Private channels where they are a working group member Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Jan 16, 2026
- Fix channel activity query to use slack_ts instead of created_at - Remove aao-admin from exclusion list (was blocking indexing) - Add access control for private channels based on working group membership - Filter search results to only show channels user has access to - Only index private channels that have linked working groups - Add getAccessiblePrivateChannelIds for efficient membership lookup - Add getWorkingGroupIdsByUser for local membership queries This ensures users can only see search results from: 1. Public channels (accessible to all workspace members) 2. Private channels where they are a working group member Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Jan 20, 2026
- Fix channel activity query to use slack_ts instead of created_at - Remove aao-admin from exclusion list (was blocking indexing) - Add access control for private channels based on working group membership - Filter search results to only show channels user has access to - Only index private channels that have linked working groups - Add getAccessiblePrivateChannelIds for efficient membership lookup - Add getWorkingGroupIdsByUser for local membership queries This ensures users can only see search results from: 1. Public channels (accessible to all workspace members) 2. Private channels where they are a working group member Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slack_ts) instead of database record creation time (created_at)aao-adminfrom the exclusion list so it can be indexedSecurity
This PR addresses a potential information leak where users could search for keywords and receive results from private channels they don't have access to.
Private channel access is now determined by:
Test plan
🤖 Generated with Claude Code