refactor: Extract package update schema and add reporting_webhook support#793
Closed
bokelley wants to merge 1 commit into
Closed
refactor: Extract package update schema and add reporting_webhook support#793bokelley wants to merge 1 commit into
bokelley wants to merge 1 commit into
Conversation
…port Split package schema into three clear variants: - package-request.json (create): Full package with product_id, format_ids, pricing_option_id - package-update.json (update): Only updatable fields, omits immutable fields - package.json (response): Reflects current package state Adds reporting_webhook to update_media_buy, enabling modification of reporting configuration after campaign creation. Keeps push_notification_config separate for async operation notifications. This unifies schema definitions, eliminates duplication, and resolves the issue where reporting setup could not be updated post-launch without recreating the media buy. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
| | `creative_ids` | string[] | Replace assigned creatives | | ||
| | `creative_ids` | string[] | Replace assigned creatives (by library ID) | | ||
| | `creatives` | CreativeAsset[] | Upload and assign new creatives inline | | ||
| | `creative_assignments` | CreativeAssignment[] | Assignments with weights and placement targeting | |
There was a problem hiding this comment.
We are mising changes between this PR and https://github.com/adcontextprotocol/adcp/pull/789/changes
| "$ref": "/schemas/media-buy/package-update.json" | ||
| } | ||
| }, | ||
| "reporting_webhook": { |
There was a problem hiding this comment.
Let's extract reporting_webhook config to a separate file since it's used both here and in create_media_buy?
Contributor
Author
|
Combining with #789 to avoid conflicts - both address Marek's feedback on update_media_buy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split package schema into three clear variants: package-request.json for creation, package-update.json for updates, and package.json for responses. Added reporting_webhook to update_media_buy, enabling modification of reporting configuration after campaign creation.
Changes
Resolves
Fixes issue where reporting configuration could not be updated post-launch without recreating the media buy.