fix: Verify unverified domains when linking to org#828
Merged
Conversation
When clicking "Link to Org" for an organization in the "Organizations Without Verified Domains" section, the API was returning success but the org remained in the list. This happened because the domain existed in organization_domains with verified=false, and the endpoint returned early without checking the verified status. Now the endpoint checks if the existing domain is verified before returning early. If not verified, it continues to the verification logic which updates both WorkOS and the local DB. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/admin/organizations/:orgId/domainsendpoint now correctly verifies existing unverified domains instead of returning early with "Domain already associated"Problem
When clicking "Link to Org" for an organization in the "Organizations Without Verified Domains" section on the domain health page, the API returned success but the org remained in the list. This happened because:
organization_domainstable but withverified = falseverified = trueSolution
Added a check for the
verifiedflag before returning early. If the domain exists for this org but is not verified, the code continues to the verification logic which:verified = trueTest plan
🤖 Generated with Claude Code