fix: Handle pending invitations in auto-add domain users feature#829
Merged
Conversation
The auto-add domain users backfill was showing users as "can be added" when they actually had pending invitations that hadn't been accepted yet. Root cause: WorkOS's listOrganizationMemberships only returns active memberships, not pending invitations. When trying to add these users, WorkOS returns error code "cannot_reactivate_pending_organization_membership". Changes: - Status endpoint now checks pending invitations and excludes those users - Backfill endpoint handles both "organization_membership_already_exists" and "cannot_reactivate_pending_organization_membership" as skip conditions - Fixed error code checking in organizations.ts endpoints (was checking error message strings instead of error codes) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
WorkOS's
listOrganizationMembershipsonly returns active memberships, not pending invitations. When the backfill tried to add users with pending invitations, WorkOS returnedcannot_reactivate_pending_organization_membershiperror, which was being counted as an error instead of a skip.Changes
organization_membership_already_existsandcannot_reactivate_pending_organization_membershipas skip conditionserrorMessage.includes()instead oferr?.code)Test plan
🤖 Generated with Claude Code