feat: Add debug logging to AdCP tools and clarify probe messaging#830
Merged
Conversation
- Add `debug` parameter to all 10 AdCP tool schemas for protocol-level visibility - Include debug_logs in tool output when debug mode enabled - Remove redundant `call_adcp_agent` tool (individual tools provide better validation) - Fix `probe_adcp_agent` messaging to clarify connectivity vs protocol compliance Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debugparameter to all 10 AdCP tool schemas for protocol-level visibilitycall_adcp_agenttool (individual tools provide better schema validation)probe_adcp_agentmessaging to clarify connectivity vs protocol complianceChanges
Debug Logging
Users can now pass
debug: trueto any AdCP tool (get_products, create_media_buy, sync_creatives, etc.) to see protocol-level details including requests, responses, and schema validation logs.Tool Consolidation
Removed the generic
call_adcp_agenttool since the individual typed tools (get_products, create_media_buy, etc.) provide better schema documentation and validation for Claude.Clearer Messaging
Updated
probe_adcp_agentto clearly state it only verifies connectivity (agent responds to HTTP), not protocol compliance. The tool now suggests runningtest_adcp_agentto verify the agent implements the protocol correctly.Test plan
🤖 Generated with Claude Code