Skip to content

Release #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addon-stack merged 5 commits into from
Oct 11, 2025
Merged

Release #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62cd739
Merge main into develop
github-actions[bot] Oct 6, 2025
93a1d39
refactor(ci): cleanup husky pre-commit and remove lint-staged configu…
addon-stack Oct 10, 2025
272b151
fix(sidebar): address incorrect type for `ColorArray` and document Op…
addon-stack Oct 10, 2025
9f55dc7
refactor(management): use stricter typing for launchType
addon-stack Oct 10, 2025
cd26f6c
refactor(sidebar): enhance sidebar API support for Opera and Firefox
addon-stack Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(management): use stricter typing for launchType
  • Loading branch information
@addon-stack
addon-stack committed Oct 10, 2025
commit 9f55dc703e9c829fc5870181d4f09548cc4dba7f
2 changes: 1 addition & 1 deletion src/action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {handleListener} from "./utils";
type Action = typeof chrome.action;
type BrowserAction = typeof chrome.browserAction;

type ColorArray = chrome.action.ColorArray;
type ColorArray = chrome.extensionTypes.ColorArray;
type TabIconDetails = chrome.action.TabIconDetails;
type UserSettings = chrome.action.UserSettings;
type Color = string | ColorArray;
Expand Down
3 changes: 2 additions & 1 deletion src/management.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {throwRuntimeError} from "./runtime";
import {handleListener} from "./utils";

type ExtensionInfo = chrome.management.ExtensionInfo;
type LaunchType = chrome.management.LaunchType;

const management = () => browser().management;

Expand Down Expand Up @@ -124,7 +125,7 @@ export const setExtensionEnabled = async (id: string, enabled: boolean): Promise
});
});

export const setExtensionLaunchType = async (id: string, launchType: string): Promise<void> =>
export const setExtensionLaunchType = async (id: string, launchType: `${LaunchType}`): Promise<void> =>
new Promise<void>((resolve, reject) => {
management().setLaunchType(id, launchType, () => {
try {
Expand Down