Skip to content

Fixed bug - amStartArgs not accepted in "launch" config#151

Open
jamesikanos wants to merge 2 commits into
adelphes:masterfrom
jamesikanos:James/Task/AcceptAMStartArgs
Open

Fixed bug - amStartArgs not accepted in "launch" config#151
jamesikanos wants to merge 2 commits into
adelphes:masterfrom
jamesikanos:James/Task/AcceptAMStartArgs

Conversation

@jamesikanos

Copy link
Copy Markdown

I was testing modifications to the AOSP Settings app in VSCode.

When launching a debugger using a config similar to below, the error: "Launch failed: No valid launch activity found in AndroidManifest.xml or launch.json".

Code was not checking for a valid amStartArgs. Modified to accept a non-zero-length array for amStartArgs.

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch Settings",
            "type": "android",
            "request": "launch",
            "targetDevice": "emulator-5554",
            "appSrcRoot": "${workspaceFolder}/packages/apps/Settings",
            "amStartArgs": [
                "-D",
                "--activity-brought-to-front",
                "-n com.android.settings/.homepage.SettingsHomepageActivity"
            ],
            "apkFile": "${workspaceRoot}/out/target/product/emulator_x86_64/system_ext/priv-app/Settings/Settings.apk"
        }
    ]
}

@greg-maher-ctct greg-maher-ctct left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think conditional check is redundant should be removed totally (as the fix). The correct check is performed in startLaunchActivity. @jamesikanos Thanks for lodging this PR, it saved me a heap of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants