Skip to content

fix: usage of contentSourceEditPattern#804

Merged
mhaack merged 2 commits intomainfrom
issue-803
Feb 25, 2026
Merged

fix: usage of contentSourceEditPattern#804
mhaack merged 2 commits intomainfrom
issue-803

Conversation

@mhaack
Copy link
Contributor

@mhaack mhaack commented Feb 24, 2026

Description

A configured custom edit url should always be used first.

Related Issue

fix: #803

@mhaack mhaack requested a review from rofe February 24, 2026 14:55
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mhaack
Copy link
Contributor Author

mhaack commented Feb 24, 2026

@rofe @auniverseaway please have a look, we introduced editUrlLabel and editUrlPattern with #245 back the the page status did not return and edit URL for BYOM I remember. But now, at least for DA, it does return an edit URL, hence to config does not work any more.

@rofe
Copy link
Contributor

rofe commented Feb 24, 2026

@mhaack can you add a test clarifying the intended behavior?

@rofe
Copy link
Contributor

rofe commented Feb 24, 2026

for DA, it does return an edit URL, hence to config does not work any more.

that change was intentional: the assumption was that if an edit URL is provided by the backend, it should supercede the config pattern.

@mhaack
Copy link
Contributor Author

mhaack commented Feb 24, 2026

that change was intentional: the assumption was that if an edit URL is provided by the backend, it should supercede the config pattern.

Ok my change would do the opposite. Customers (DA) want to overwrite the edit URL provided by the backend, for example to open UE directly instead of the doc based editor.

@mhaack
Copy link
Contributor Author

mhaack commented Feb 24, 2026

@rofe added as test as well

@mhaack mhaack merged commit e667151 into main Feb 25, 2026
5 checks passed
@mhaack mhaack deleted the issue-803 branch February 25, 2026 09:18
github-actions bot pushed a commit that referenced this pull request Feb 25, 2026
## [7.28.2](v7.28.1...v7.28.2) (2026-02-25)

### Bug Fixes

* usage of contentSourceEditPattern ([#804](#804)) ([e667151](e667151))
@github-actions
Copy link

🎉 This PR is included in version 7.28.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

editUrlPattern in sidekick config is ignored

2 participants