CEXT-5236: Separating service urls based on execution context - #36
Merged
Conversation
10 tasks
nofuss
approved these changes
Oct 7, 2025
| }, | ||
| [constants.EXECUTION_CONTEXT.EXTERNAL]: { | ||
| [constants.PROD_ENV]: 'https://db.<region>.adobe.test', | ||
| [constants.STAGE_ENV]: 'https://db-stage.<region>.adobe.test' |
Collaborator
There was a problem hiding this comment.
maybe excessively picky, but might as well use stg to be consistent with the pattern elsewhere.
Collaborator
Author
There was a problem hiding this comment.
This led to me finding a bug in how I was mocking (or rather, not mocking) getCliEnv(), so thanks for being picky! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running inside a runtime action, use the internal endpoint for the service, otherwise use the external endpoint.
Related Issue
CEXT-5236: aio-lib-db to use correct urls depending on context
Motivation and Context
When running inside a runtime action, use the internal endpoint for the service, otherwise use the external endpoint.
How Has This Been Tested?
Unit testing. Manual tests require the code to be run from inside a deployed ethos cluster and cannot be done locally.
Screenshots (if appropriate):
Types of changes
Checklist: