Skip to content

GH-125 add new webhook module for payload authentication#144

Merged
francoisledroff merged 33 commits into
mainfrom
GH-125
Feb 7, 2023
Merged

GH-125 add new webhook module for payload authentication#144
francoisledroff merged 33 commits into
mainfrom
GH-125

Conversation

@abhupadh

@abhupadh abhupadh commented Jan 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

adds new module events_webhook which has the

  • payload recipient verification
  • I/O Events webhook signature verification method

Related Issue

created on top of the changes in this #125

Motivation and Context

Helps I/O Events Customers to setup their webhook verification using this sdk feature.

How Has This Been Tested?

Has the test EventVerifierTest which tests the api for verifying signature.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

abhupadh and others added 19 commits June 23, 2022 14:37
events_webhook module with signature verification feature and test
15c8edd
modified core, webhook and main pom, events_webhook module classes
e9aaf18
missing return statement
75a5678
adding EventVerifierBuilder
f0d83a1
refactoring event verifier, using map cache, open fiegn for http call
914e0e7
adding api, feign service, cache, model
cd94980
updating test
1f64507
updating poms
01f11d5
minor refactoring
2af9561
@abhupadh
Merge branch 'main' into CI-5472
2b59c46
removing caffeine, retrofit, other unwanted dependencies
8fa9f04
refactoring hashmap used cache service
6d5b8bb
refactoring event verifier and its test
a2f77f6
updating main pom with required dependencies, removing caffiene, retr…
5d1859d 
…ofit and unwanted dependecies
removing commented sentences
250cc7f
removing spring context dependency
df90b84
removing Service annotation, minor refactoring
2bdc23e
Merge remote-tracking branch 'abhupadh-changes/CI-5472' into main
e767650 
pulling changes of my own branch
deleting cache feature
61f75c6
@abhupadh abhupadh temporarily deployed to aio_prod January 31, 2023 20:49 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_prod January 31, 2023 20:54 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_prod February 2, 2023 02:08 — with GitHub Actions Inactive
francoisledroff
francoisledroff reviewed Feb 2, 2023
View reviewed changes
Comment thread events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java Outdated
francoisledroff
francoisledroff reviewed Feb 2, 2023
View reviewed changes
Comment thread events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java Outdated
francoisledroff
francoisledroff reviewed Feb 2, 2023
View reviewed changes
Comment thread events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java Outdated
francoisledroff
francoisledroff reviewed Feb 2, 2023
View reviewed changes
Comment thread events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java Outdated
francoisledroff
francoisledroff reviewed Feb 2, 2023
View reviewed changes
Comment thread events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java Outdated
@abhupadh abhupadh temporarily deployed to aio_prod February 2, 2023 20:55 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_stage February 2, 2023 20:55 — with GitHub Actions Inactive
@abhupadh

abhupadh commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

@francoisledroff : please review

francoisledroff
francoisledroff reviewed Feb 3, 2023
View reviewed changes
Comment thread events_webhook/pom.xml Outdated
francoisledroff
francoisledroff reviewed Feb 3, 2023
View reviewed changes
Comment thread events_webhook/pom.xml Outdated
@abhupadh abhupadh temporarily deployed to aio_prod February 3, 2023 19:16 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_stage February 3, 2023 19:16 — with GitHub Actions Inactive
@abhupadh

abhupadh commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

@francoisledroff : please review

@abhupadh

abhupadh commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

@francoisledroff : could you please review

@abhupadh abhupadh temporarily deployed to aio_stage February 6, 2023 22:13 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_prod February 6, 2023 22:13 — with GitHub Actions Inactive
francoisledroff
francoisledroff approved these changes Feb 7, 2023
View reviewed changes

@francoisledroff francoisledroff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@francoisledroff francoisledroff merged commit e33c870 into main Feb 7, 2023
@francoisledroff francoisledroff deleted the GH-125 branch February 7, 2023 13:26
@francoisledroff francoisledroff mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francoisledroff francoisledroff francoisledroff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhupadh @francoisledroff