GH-213: enhance WorkspaceUtil to also search in envrionment variables#214
Merged
Conversation
francoisledroff
requested changes
Feb 1, 2024
| try { | ||
| Workspace workspace = WorkspaceUtil.getSystemWorkspaceBuilder().build(); | ||
| Workspace workspace = WorkspaceUtil.getWorkspaceBuilder().build(); | ||
| String providerId = WorkspaceUtil.getSystemProperty(AIO_PROVIDER_ID); |
Collaborator
There was a problem hiding this comment.
don't you want to load these other AIO_* property using the same pattern ? and augment getSystemProperty with System.getEnv() ?
|
|
||
| public static void main(String[] args) { | ||
| try { | ||
| Workspace workspace = WorkspaceUtil.getSystemWorkspaceBuilder().build(); |
Collaborator
There was a problem hiding this comment.
I would favor keeping the same interface/method-name
Collaborator
Author
There was a problem hiding this comment.
ok I'll revert back the change
francoisledroff
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #213
Description
As described in the issue, added the possibility to get the configuration for the
Workspacefrom environment variables, which makes it easier to use.Related Issue
#213
Motivation and Context
Enable the usage of environment variables in docker containers where an entrypoint is defined in exec form, passing the configurations through ENV variables without the need to bind them using the system properties, which turns out to be really cumbersome.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: