Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Updated Brackets Extensibility - from brackets/src/extensibility/node to brackets-registry/deps/brackets-extensibility#76

Merged
swmitra merged 4 commits into
masterfrom
saurabh95/UpdateBracketsExtensibility
Mar 10, 2017
Merged

Updated Brackets Extensibility - from brackets/src/extensibility/node to brackets-registry/deps/brackets-extensibility#76
swmitra merged 4 commits into
masterfrom
saurabh95/UpdateBracketsExtensibility

Conversation

@saurabh95

Copy link
Copy Markdown
Collaborator

No description provided.

@ficristo

Copy link
Copy Markdown
Collaborator

We should update the deps at Brackets first.

@saurabh95

saurabh95 commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator Author

@ficristo You mean merging this first, adobe/brackets#12933 ?

@zaggino

zaggino commented Feb 26, 2017

Copy link
Copy Markdown
Contributor

In my opinion, we shouldn't have a tar file here. The more transparent way would be just to create a folder here like lib-brackets or something and copy the files from brackets there, with a note that this file is a copy of https://.... in adobe/brackets. I don't think there's any bonus of having this archive here. Dependencies can be extracted to root package.json

@saurabh95

saurabh95 commented Feb 27, 2017

Copy link
Copy Markdown
Collaborator Author

Yeah using folder instead of tar would be better. I will add the steps in the wiki, so that it is easy to port changes from brackets to registry in future.
Also once we are done with upgrading node in the brackets-registry prod server, then we can merge adobe/brackets#12933 and then I will pull the latest brackets-extensibility from brackets to registry.

@petetnt

petetnt commented Feb 27, 2017

Copy link
Copy Markdown

Why don't we just yank the dependency out and publish it to npm and install it with npm?

@zaggino

zaggino commented Feb 27, 2017

Copy link
Copy Markdown
Contributor

That's probably the best solution :)

@ficristo

Copy link
Copy Markdown
Collaborator

If this PR is a prerequisite to update the extensibility/node deps, I'm fine with it.

@saurabh95 saurabh95 changed the title Updated Brackets Extensibility - from brackets/src/extensibility/node to brackets-registry/deps Updated Brackets Extensibility - from brackets/src/extensibility/node to brackets-registry/deps/brackets-extensibility Mar 10, 2017
@swmitra

swmitra commented Mar 10, 2017

Copy link
Copy Markdown
Collaborator

I am fine with this approach for now as it can complement the extensiblity dependency management PR by @zaggino. I am merging this PR, so that I can merge the other PR by @zaggino as well.

@swmitra swmitra merged commit d1862b4 into master Mar 10, 2017
@petetnt petetnt deleted the saurabh95/UpdateBracketsExtensibility branch March 10, 2017 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants