"Go Live" not working with inline CSS editor on Windows

[adrocknaphobia]

1. On index.html I click “Go Live”. Browser opens. Page shown. All good.
2. Open impress.css file and edit h1 class, updates happen live. Awesome.
3. Use the inline editor on index.html to edit h1 class, CSS updated not shown live.
4. Click on impress.css file in the sidebar, browser instantly updates.

Unzipped from the Sprint 06 Build running on Windows 7. Happening on multiple machines. Works fine on Mac (10.7.2).

[adrocknaphobia]

Here is the project zipped up. Just a simple impress.js preso.

http://dl.dropbox.com/u/8136628/Introducing%20Brackets.zip

[peterflynn]

I can repro on my XP machine too.

Note: step 2 is optional. It also repros if you skip step 2.

Looks like a bug in the live editing code -- the CSSDocument that monitors changes to the .css file is destroyed whenever you switch away from the full-size editor, and recreated again when you switch back (even though the full-size editor itself is not getting destroyed/recreated -- it stays in the working set the whole time).

Because the CSSDocument isn't around when editing in the inline, those changes don't get picked up until you switch back to the full-size editor, triggering recreation of the CSSDocument and kicking it to update.

[peterflynn]

The core issue seems to be that:

• Whenever you switch editors, LiveDevelopment._onDocumentChange() disconnects from the browsers and immediately reconnects. I'm not sure why it does this if you haven't actually changed to a different HTML document.
• When reconnecting, LiveDevelopment._openDocument() is supposed to look up all CSS files that the document loads and start tracking them all right away. Yet in some projects (such as this one), it fails to notice CSS files that are indeed being loaded.
  But clearly, since we tested and demoed live development with inline editing, it does notice the CSS files in some other projects. Afaict though, Adam's project isn't doing anything weird -- the file is statically linked in right in the head, not loaded via JS or anything else unusual.

[adrocknaphobia]

So believe it or not, this seems to be caused by spaces in the path.

When I moved C:\Users\adlehman\Documents\My Dropbox\Presos\Brackets\Introducing Brackets to: C:\Introducing-Brackets (no spaces) everything works as it’s supposed to.

I tried just removing the space from the project directory, but it seems that if there is a space anywhere in the path it breaks the inline editor and “go live” mode.

Sounds like we might want to start adding some more unit tests that include spaces in the directory and paths.

-Adam

[peterflynn]

Not surprising -- sounds like a URL/path conversion escaping problem in the code that identifies which CSS files were loaded by the browser.

[gruehle]

@RaymondLim - could you regress and close this? Thanks.

[RaymondLim]

Fix verified.