Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Upgrade less from 2.5.1 to 2.7.2#13019

Merged
zaggino merged 1 commit into
adobe:masterfrom
ficristo:less
Jan 9, 2017
Merged

Upgrade less from 2.5.1 to 2.7.2#13019
zaggino merged 1 commit into
adobe:masterfrom
ficristo:less

Conversation

@ficristo

@ficristo ficristo commented Jan 2, 2017

Copy link
Copy Markdown
Collaborator

I would like to upgrade grunt related dependencies and this was in the way: updating only the grunt dep without the thirdparty didn't seem good.
I renamed less-2.5.1.min.js to simply less.min.js, you can see the version in the comments inside the file.

@zaggino

zaggino commented Jan 2, 2017

Copy link
Copy Markdown
Contributor

could we maybe switch to npm dependency instead?

@ficristo

ficristo commented Jan 2, 2017

Copy link
Copy Markdown
Collaborator Author

I'm all for moving to npm.
But has pointed out before by @busykai, we need to do something about the increase size of the bundle.
For example less 2.7.1 from npm is about 3MB, but the minified file is only 140kB.
I have some random thought but still nothing good.
So WDYT?

@zaggino

zaggino commented Jan 2, 2017

Copy link
Copy Markdown
Contributor

Is it about npm not providing minified file or about npm providing too many files that we don't need?

@ficristo

ficristo commented Jan 3, 2017

Copy link
Copy Markdown
Collaborator Author

Too many files, I've opened #13020 as a possible solution

@ficristo

ficristo commented Jan 8, 2017

Copy link
Copy Markdown
Collaborator Author

Now it is fetched from npm.

@ficristo ficristo changed the title Upgrade less from 2.5.1 to 2.7.1 Upgrade less from 2.5.1 to 2.7.2 Jan 8, 2017
@zaggino zaggino merged commit 034215c into adobe:master Jan 9, 2017
@zaggino

zaggino commented Jan 9, 2017

Copy link
Copy Markdown
Contributor

👍 cool

@ficristo ficristo deleted the less branch January 9, 2017 18:55
@ficristo

ficristo commented Jan 9, 2017

Copy link
Copy Markdown
Collaborator Author

Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants