-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Spanish translation update #9078
Conversation
Minor changes were made to the following sections in order to express the sentence or phrase more fluently for the reader in the native language. - "ERROR_PREFS_CORRUPT" - "ERROR_IN_BROWSER" - "ERROR_MAX_FILES" - "ERROR_LAUNCHING_BROWSER_TITLE" - "ERROR_FETCHING_UPDATE_INFO_MSG" - "ERROR_QUICK_EDIT_PROVIDER_NOT_FOUND" - "ERROR_QUICK_DOCS_PROVIDER_NOT_FOUND" - "ABOUT_TEXT_WEB_PLATFORM_DOCS" - "CANNOT_WRITE_TEMP"
Minor changes were made to the following sections in order to express the sentence or phrase more fluently for the reader in the native language.
src/nls/es/strings.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: There are 2 spaces between con and proyectos.
|
Thanks for the fixes. You need to sign the Contribution Agreement before we can merge it. |
Fixed 2 spaces between con and proyectos as per TomMalbran revision.
|
Contribution Agreement already signed. Do you agree with the explanation of line 411? |
|
Fixing name. @jamesxv7 for future reference, you can give your pull requests a more descriptive name on the "New Pull Request" screen, before you click "Send Pull Request." (The same screen where you enter the longer description shown in small text at the top of this page: "Minor changes were made to the following sections...") |
src/nls/es/strings.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this line? The sha is grabbed from here: https://github.com/adobe/brackets/commits/master/src/nls/root/strings.js when the file is changed to have the same strings as root/strings.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, line already reverted.
|
@jamesxv7 It looks good. I'll merge it after you fix the sha issue. Thanks |
Revert SHA as per @TomMalbran
|
@jamesxv7 Thanks. Merging |
|
@peterflynn Thanks a lot for the tip and the correction. I'm currently learning to use the tool (GitHub) and taking more seriously the invested in projects that capture my interest. Brackets is awesome. |
Minor changes were made to the following sections in order to express the sentence or phrase more fluently for the reader in the native language.