Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
auniverseaway
requested changes
Feb 26, 2026
Member
auniverseaway
left a comment
auniverseaway
left a comment
There was a problem hiding this comment.
Small nit. Otherwise looks good. Glad someone is using this feature and polishing it down to be truly useful.
| disconnectedCallback() { | ||
| super.disconnectedCallback(); | ||
| window.removeEventListener('keydown', this.handleKeydown); | ||
| window.dispatchEvent(new CustomEvent('da-library-close', { composed: true })); |
Member
There was a problem hiding this comment.
These should be scoped to the library component, not the window.
It will be a touch annoying to get to in the DOM via web components / shadow dom and inside your Prose plugin, but it's the right thing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open a document for editing, select some content and click on the Library icon: the selection disappear.
Root cause: the focus is set on the search input of the library.
Browser cannot have a focused element and a selection at the same time. Gemini created this proposal which is to create a fake overlay. Not perfect and pretty complicated.
Test url: https://fakesel--da-live--adobe.aem.live/