Skip to content
This repository was archived by the owner on Feb 28, 2022. It is now read-only.
This repository was archived by the owner on Feb 28, 2022. It is now read-only.

Clarify request url, path and introduce root #170

@tripodsan

Description

@tripodsan

When a strain is selected with a URL condition, it is expected that the content repository is mounted below the url path. for example:

strain:
  url: https://www.project-helix.io/docs/api
  content: https://github.com/adobe/helix-docs.git#master/documentation.

should map a request of https://www.project-helix.io/docs/api/general/index.html?a=1 to
https://github.com/adobe/helix-docs.git#master/documentation/general/index.md.

the context.request object should have:

property value comment
url /docs/api/general/index.html?a=1 the original client request url
path /general/index.md the resource path
root /docs/api new: The mount root

Suggest

It might be confusing to have request.path different from request.url. so I suggest to introduce resourcePath, and keep the path the original client path.

property value comment
url /docs/api/general/index.html?a=1 the original client request url
path /docs/api/general/index.html the original request path
resourcePath2 /general/index.md the resource path
root /docs/api The mount root

2 Alternative: contentPath

/cc @trieloff, @kptdobe @stevengill

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestquestionFurther information is requested

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions