Skip to content

Fix executing interpolation when skip_interpolations is True#113

Merged
danielcoman merged 1 commit intomasterfrom
fix_88
Sep 30, 2022
Merged

Fix executing interpolation when skip_interpolations is True#113
danielcoman merged 1 commit intomasterfrom
fix_88

Conversation

@danielcoman
Copy link
Contributor

Description

Fixes #88

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danielcoman
Copy link
Contributor Author

Fixes #88

@danielcoman
Copy link
Contributor Author

@ecojan seems resolve_env is and interpolation and should respect skip_interpolations bool. Can you please check this change is not breaking any expected behavior?

@danielcoman danielcoman requested a review from ecojan September 27, 2022 19:07
Copy link
Collaborator

@ecojan ecojan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense, seeing as all interpolations should be skipped if the flag is set to true (and env variables, just like secrets) could be treated as such.

@danielcoman danielcoman merged commit 959ddda into master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConfigProcessor.process(skip_interpolations=True) flag not working as expected

2 participants