Fix executing interpolation when skip_interpolations is True#113
Merged
danielcoman merged 1 commit intomasterfrom Sep 30, 2022
Merged
Fix executing interpolation when skip_interpolations is True#113danielcoman merged 1 commit intomasterfrom
danielcoman merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
Fixes #88 |
Contributor
Author
|
@ecojan seems |
ecojan
approved these changes
Sep 30, 2022
Collaborator
ecojan
left a comment
There was a problem hiding this comment.
Change makes sense, seeing as all interpolations should be skipped if the flag is set to true (and env variables, just like secrets) could be treated as such.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #88
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: