Addded support for config_merger filtering of root properties#162
Merged
danielcoman merged 3 commits intoadobe:masterfrom Jan 30, 2024
Merged
Addded support for config_merger filtering of root properties#162danielcoman merged 3 commits intoadobe:masterfrom
danielcoman merged 3 commits intoadobe:masterfrom
Conversation
9a0a80b to
f7d47f8
Compare
ecojan
approved these changes
Jan 30, 2024
52f2a27 to
821bf6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows filtering the output config properties from himl-config-merger. Filter rules are part of the configs and can be defined hierarchically. The rules sit under a key that is passed as an argument to the tool through
--filter-rules-keyRelated Issue
--
Motivation and Context
Output configs can become very big when values are being reused/interpolated between levels or on the same level. For example a property defined at the root level is only needed by a subset of clusters. To minimize the output, the only partial solution currently is to overwrite that property for all the leaf paths that don't need it. When configuring multiple clusters/services, default properties get populated and are never used.
How Has This Been Tested?
Added a hierarchy with filters in the examples folder with values convering multiple scanarios:
Screenshots (if appropriate):
Types of changes
Checklist: