Merged
Conversation
dzehnder
reviewed
Nov 30, 2023
| * @returns {boolean} True if the parameter is an array, false otherwise. | ||
| */ | ||
| function isArray(value) { | ||
| return Array.isArray(value); |
Contributor
There was a problem hiding this comment.
why do we need the roundtrip through the utils for this? Are we planning any additional checks in the future?
Also we could reuse the util function in isObject and arrayEquals
|
This PR will trigger a minor release when merged. |
solaris007
approved these changes
Nov 30, 2023
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!