fix(onboard-status): show no-scrape-data scraping state as neutral, not failed - #343
Merged
Merged
Conversation
…ot failed Follow-up to #340 (merged): the onboarding status report mapped the 'unknown' scraping state (no scrape data yet) to ❌, which reads as a failure on an early snapshot of a not-yet-scraped site — the running-vs-failed conflation #340 set out to remove. Map 'unknown' to a neutral info icon (ℹ️): not ❌ (false failure) and not ⏳ (overclaims active progress). A genuinely terminal-failed scrape (0 completed, 0 pending, >0 failed) still resolves to ❌ via the tri-state. Mirrors the same fix in spacecat-api-service's onboard-status command, keeping the two deriveScrapingStatus consumers in sync. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Merging it as it is simple change to fix a reporting bug. |
Member
|
🎉 This PR is included in version 1.16.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #340 (merged)
Small correctness fix on the onboarding status report's scraping data-source line.
Problem: the
unknownscraping state — no scrape data yet (getScrapingStats/isScrapingAvailablefound no jobs or no URL results for the current onboarding) — mapped to ❌. On an early snapshot of a not-yet-scraped site that reads as a failure, the exact running-vs-failed conflation #340 set out to remove. It also contradicted the accompanying "Scraping is in progress or no results available yet" text.Fix: map
unknownto a neutral ℹ️ (:information_source:) — not ❌ (false failure) and not ⏳ (which would overclaim active progress). A genuinely terminal-failed scrape (0 completed, 0 pending, >0 failed) still resolves to ❌ via the tri-state;in_progress(URLs pending) stays ⏳;availablestays ✅.Surfaced by review of the sibling change in spacecat-api-service (#2974); this keeps the two
deriveScrapingStatusconsumers in sync.Tests
Full suite green (415 passing), coverage gate passes, lint clean.
🤖 Generated with Claude Code