Skip to content

[MWPW-179699] [PREFLIGHT] Added a11y links localization check#5169

Merged
milo-pr-merge[bot] merged 6 commits intostagefrom
mwpw-179699
Mar 2, 2026
Merged

[MWPW-179699] [PREFLIGHT] Added a11y links localization check#5169
milo-pr-merge[bot] merged 6 commits intostagefrom
mwpw-179699

Conversation

@robert-bogos
Copy link
Contributor

@robert-bogos robert-bogos commented Nov 28, 2025

Description

This PR is adding links localization checks to the General tests in Preflight.

Related Issue

Resolves: MWPW-179699

Testing instructions

  1. open Preflight on the test page
  2. go to the Accessibility tab
  3. see the violations entries for links localization

Test URLs

Milo:

CC:

@robert-bogos robert-bogos self-assigned this Nov 28, 2025
@robert-bogos robert-bogos requested a review from a team as a code owner November 28, 2025 19:31
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Nov 28, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@NadiiaSokolova NadiiaSokolova requested a review from a team December 1, 2025 11:59
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Dec 9, 2025
@github-actions
Copy link
Contributor

Closing this PR due to inactivity.

@github-actions github-actions bot closed this Dec 16, 2025
@robert-bogos robert-bogos reopened this Dec 16, 2025
@github-actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@github-actions
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Dec 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

Closing this PR due to inactivity.

@github-actions github-actions bot closed this Jan 1, 2026
@robert-bogos robert-bogos reopened this Jan 8, 2026
@github-actions github-actions bot removed the Stale label Jan 9, 2026
Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only gave it a spot-check but looks good to me

@github-actions
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

Copy link
Contributor

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robert-bogos !
I couldn't see any links being marked in the accessibility tab on the after links. Has something changed on these pages or am I testing wrong?

@NadiiaSokolova
Copy link
Contributor

Hey @robert-bogos ! I couldn't see any links being marked in the accessibility tab on the after links. Has something changed on these pages or am I testing wrong?

Hi @vhargrave! The links are in General tab.

@NadiiaSokolova NadiiaSokolova self-assigned this Feb 4, 2026
@github-actions
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Feb 12, 2026
Copy link
Contributor

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details MWPW-179699

@milo-pr-merge milo-pr-merge bot merged commit 378cb06 into stage Mar 2, 2026
24 of 32 checks passed
@milo-pr-merge milo-pr-merge bot deleted the mwpw-179699 branch March 2, 2026 09:46
@milo-pr-merge milo-pr-merge bot mentioned this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants