Skip to content

MWPW-185132 [ABC] Milo changes to acomodate new ABC Web SDK changes to onboard on BC GA Version#5414

Merged
milo-pr-merge[bot] merged 6 commits intoadobecom:stagefrom
sharg1:stage
Feb 12, 2026
Merged

MWPW-185132 [ABC] Milo changes to acomodate new ABC Web SDK changes to onboard on BC GA Version#5414
milo-pr-merge[bot] merged 6 commits intoadobecom:stagefrom
sharg1:stage

Conversation

@sharg1
Copy link
Contributor

@sharg1 sharg1 commented Feb 10, 2026

  • Milo changes to acomodate new ABC Web SDK changes to onboard on BC GA Version

Resolves: MWPW-185132

Test URLs:

Launch changes are added to XLG-Stage. Hence, works across all stage sites. No need to override the Launch lib using AEP event debugger.

BC Response in chat
image

Launch lib version:
image

Screen.Recording.2026-02-11.at.3.00.54.PM.mov
Screen.Recording.2026-02-11.at.2.59.52.PM.mov

@github-actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@sharg1 sharg1 self-assigned this Feb 11, 2026
@sharg1 sharg1 added the needs-verification PR requires E2E testing by a reviewer label Feb 11, 2026
@sharg1 sharg1 marked this pull request as ready for review February 11, 2026 09:25
@sharg1 sharg1 assigned Nadeemakramn and unassigned sharg1 Feb 11, 2026
@Nadeemakramn
Copy link

Changes Verified, Go to Live.

image image

@Nadeemakramn Nadeemakramn added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Feb 11, 2026
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Feb 11, 2026

Skipped merging 5414: MWPW-185132 [ABC] Milo changes to acomodate new ABC Web SDK changes to onboard on BC GA Version due to failing or running checks

@colloyd colloyd requested a review from JackySun9 February 11, 2026 14:30
Copy link
Contributor

@colloyd colloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've even pulled the changes into my branch and everything seems to be working. Let's just get these unit test issues resolved and we're good to go.

Implement new bootstrap API for loading scripts based on Alloy version.
Added mock for alloy version 2.31.0 in multiple tests and updated script loading logic.
@sharg1 sharg1 added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Feb 11, 2026
@sharg1
Copy link
Contributor Author

sharg1 commented Feb 11, 2026

Added high priority label as some of the stage brand concierge pages, the modal is not loading on chat. cc @colloyd @JackySun9

@milo-pr-merge milo-pr-merge bot merged commit a0a8725 into adobecom:stage Feb 12, 2026
13 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Feb 12, 2026
antonio-rmrz added a commit that referenced this pull request Feb 24, 2026
… MWPW-180167-b

* 'MWPW-180167-b' of https://github.com/adobecom/milo: (41 commits)
  MWPW-188304 Brand Concierge - Fix bootstrap api race condition (#5448)
  MWPW-187769: bulk publisher guardrails (#5421)
  [MWPW-186048] Updated LANA logs to use severity levels correctly  (#5416)
  MWPW-182174: Exclude cards from showing on themselves (#5389)
  stage: preserve absolute paths (#5441)
  MWPW-185171 Article acessibility (#5358)
  [MWPW-188224] Updating countryCode for cart flow (#5436)
  MWPW-187479 Long Term CSAT UI Html Fix (#5429)
  MWPW-188101 [MEP] Fixes highlight changes interaction issue (#5428)
  Brand Concierge - Floating Button (#5427)
  MWPW-186794 [M@S Plans] Leverage spectrum icon library for filters (#5411)
  MWPW-187145 [ROW M@S] 3-in-1 fallback feature to maintain CRM on Plans page (#5384)
  MWPW-185132 [ABC] Milo changes to acomodate new ABC Web SDK changes to onboard on BC GA Version (#5414)
  MWPW-188023: prevent cors error between bacom and news: (for stage) (#5422)
  [BACOM0004] font fix (#5418)
  [MWPW-187430] - Comparison table nav sticky (#5398)
  [MWPW-185896] Exclude pages from running Preflight (#5360)
  [MWPW-183181] [Preflight] Added a11y keyboard navigation check (#5279)
  MWPW-186835 Aria-Label Added to 3in1 Modal (#5402)
  Adding metadata option to enable full width for synchronous dropdown in Gnav (#5399)
  ...

# Conflicts:
#	libs/mep/ace1151/carousel/carousel.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants