proposal 0002: validate warning for dead renames overlay entries (#19)#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft proposal for #19.
Adds a non-blocking
validatewarning (renames.dangling) for each manifestrenamesentry that resolves to no applied rename — the missing overlay-consistency mirror to the existingpolicy.dangling(policies) andrelationship.overlay_dangling(relationships) diagnostics. Core, read-only, additive; no exit-code or schema change.Key design decisions recorded in the doc:
kind: rulerename stampssource.original_idon the materialized rule; an entry is dead iff(pack, from)is absent from that applied-set. Precise reading of "frommatches no active rule."policy.dangling— a mistypedpackis indistinguishable from a legitimately-staged forward-looking one, and the warning register keeps a green repo green either way. Tiered/suppressing alternatives recorded as forks.RuleDefgains asourcefield (the model currently discards the provenance the store carries).Forks considered: do-nothing, refuse-at-
rename add,to-id heuristic, tiered forward-looking suppression, fold-into-#8.Refs #19.