Skip to content

Fix bank holder name in CGU#997

Merged
Rotheem merged 2 commits into
mainfrom
fix-bank-holder-cgu
Apr 12, 2026
Merged

Fix bank holder name in CGU#997
Rotheem merged 2 commits into
mainfrom
fix-bank-holder-cgu

Conversation

@Rotheem

@Rotheem Rotheem commented Apr 12, 2026

Copy link
Copy Markdown
Member

Description

Summary

Change bank account holder name in CGU with the one in database instead of Settings.entity_name

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov

codecov Bot commented Apr 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.43%. Comparing base (23c86e3) to head (63ceb78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #997   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files         206      206           
  Lines       14918    14922    +4     
=======================================
+ Hits        12596    12600    +4     
  Misses       2322     2322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rotheem Rotheem merged commit 5c7d46e into main Apr 12, 2026
7 checks passed
@Rotheem Rotheem deleted the fix-bank-holder-cgu branch April 12, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants