This repository was archived by the owner on Dec 5, 2019. It is now read-only.
Changed naming of checks from SecurityCheck to DeviceCheck#85
Merged
ziccardi merged 5 commits intoaerogear-attic:masterfrom Aug 9, 2018
Merged
Changed naming of checks from SecurityCheck to DeviceCheck#85ziccardi merged 5 commits intoaerogear-attic:masterfrom
ziccardi merged 5 commits intoaerogear-attic:masterfrom
Conversation
wei-lee
reviewed
Aug 8, 2018
| /// Check to determine whether the allowBackup flag is enabled for the application. | ||
| /// </summary> | ||
| public class BackupDisallowedCheck : AbstractSecurityCheck | ||
| public class BackupAllowedCheck : AbstractDeviceCheck |
Contributor
There was a problem hiding this comment.
should this be renamed to BackupEnabledCheck?
wei-lee
reviewed
Aug 8, 2018
| /// A check for whether the device the application is running on an emulator. | ||
| /// </summary> | ||
| public class NotInEmulatorCheck : AbstractSecurityCheck | ||
| public class EmulatorCheck : AbstractDeviceCheck |
Contributor
There was a problem hiding this comment.
may be changed to IsEmulatorCheck?
wei-lee
approved these changes
Aug 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JIRA: https://issues.jboss.org/browse/AEROGEAR-7742
Description
This PR changes the naming of the checks from SecurityCheck to DeviceCheck and remote the double negatves.
Progress
Additional Notes
Documentation will need to be updated accordingly