Fallback Nyx registration lookup to bounded scan#360
Merged
eanzhao merged 7 commits intoApr 24, 2026
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe4b2da93b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dev #360 +/- ##
==========================================
- Coverage 70.04% 70.04% -0.01%
==========================================
Files 1155 1155
Lines 82584 82584
Branches 10868 10868
==========================================
- Hits 57847 57845 -2
- Misses 20559 20560 +1
- Partials 4178 4179 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Add regression coverage for registration lookup, transport parsing, credential resolution, outbound delivery, and the deferred LLM reply inbox so the failure modes that could silently swallow Lark relay traffic are now pinned: - turn runner: duplicate registrations in bounded scan, scan miss falls through to Bot.Value lookup, scan skipped when OutboundDelivery absent - outbound port: missing reply_message_id, missing platform, empty rendered text, Nyx rejecting the relay reply - transport: reply_token propagation, conversation identity fallback chain (conversation.id -> platform_id -> sender -> default), ignored empty-text payloads - inbox runtime: generator throws, generator returns empty, malformed request with missing activity or target actor id - credential resolver: missing registration, missing credential_ref, whitespace-only api key id, whitespace normalization Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…x-registration-query-fallback # Conflicts: # agents/Aevatar.GAgents.ChannelRuntime/ChannelConversationTurnRunner.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lark relay traffic can still reach Aevatar, but the reply path can stop before Nyx receives
/api/v1/channel-relay/reply.Two observable issues are covered in this branch:
nyx_agent_api_key_ideven when the same registration is visible viaGET /api/channels/registrationsSolution
ChannelBotRegistrationQueryPorton the original exact-match projection query pathChannelConversationTurnRunnernyx_agent_api_key_idmissNyxIdRelayAuthValidatorImpact
ChannelConversationTurnRunnerChannelBotRegistrationQueryPortNyxIdRelayAuthValidatorChannelConversationTurnRunnerTestsRegistrationQueryPortTestsNyxIdRelayAuthValidatorTestsValidation
dotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo --filter "FullyQualifiedName~RegistrationQueryPortTests|FullyQualifiedName~ChannelConversationTurnRunnerTests|FullyQualifiedName~NyxIdRelayTransportTests"dotnet test test/Aevatar.AI.Tests/Aevatar.AI.Tests.csproj --nologo --filter "FullyQualifiedName~NyxIdRelayAuthValidatorTests|FullyQualifiedName~NyxIdChatEndpointsCoverageTests"bash tools/ci/test_stability_guards.sh