refactor: cluster-006 committed-state publication hook for projection scope activation#744
Conversation
loning
added
auto-loop
📊 状态卡片 — reviewer 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
📊 状态卡片 — reviewer 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
📊 状态卡片 — reviewer 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
🤖 Quality review: comment on one oversized routing methodTL;DR
详细说明我给出的 verdict 是 唯一质量问题在 📎 完整 codex 原始输出(存档备查)pr: 744
|
🤖 Architect review：拒绝，committed event 可能被持久化但不进入投影观察链TL;DR
详细说明阻塞点在 committed-state publication 的顺序。 这直接撞上 CLAUDE.md 条款： 另外有一个非阻塞 checklist 问题：几个新增/refactored type 只有方法级 Old/New comment，缺少 type 级 📎 完整 codex 原始输出(存档备查)pr: 744
|
🤖 Tests reviewer: 拒绝，PR 744 测试覆盖不足TL;DR
详细说明主要问题不是测试命名或小瑕疵，而是覆盖缺口。 另外， 📎 完整 codex 原始输出(存档备查)pr: 744
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## auto-refact-dev #744 +/- ##
===================================================
- Coverage 82.74% 82.48% -0.27%
===================================================
Files 954 961 +7
Lines 60374 60569 +195
Branches 7904 7922 +18
===================================================
+ Hits 49956 49959 +3
- Misses 7024 7201 +177
- Partials 3394 3409 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
📊 状态卡片 — fix 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
| /// <summary> | ||
| /// Maps service committed state events to existing durable projection scopes. | ||
| /// </summary> | ||
| public sealed class ServiceCommittedStateProjectionActivationPlanProvider : IProjectionActivationPlanProvider |
🤖 PR 744 round 2 fix 已完成TL;DR
详细说明本轮核心修复是把 测试侧补回了 reviewer 指出的覆盖缺口：dispatcher failure / missing activation service、service command 各生命周期分支、Responses agent tool parser/generated id 边界，以及 command/adapter source regression guard。quality comment 也已处理： 验证已通过： 📎 完整 codex 原始输出(存档备查)Fix report for PR 744 round 2Applied
Rejected as false positive
Blocked (cannot fix this round)
Build status
Recommendation for next round
⟦AI:AUTO-LOOP⟧ ⟦AI:AUTO-LOOP⟧ |
📊 状态卡片 — reviewer 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
loning
force-pushed
the
refactor/iter18-cluster-006-committed-state-publication
branch
from
a7873ae to
69f128f
Compare
📊 状态卡片 — reviewer 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
📊 状态卡片 — reviewer 派出
🤖 controller status banner ⟦AI:AUTO-LOOP⟧ |
⟦AI:AUTO-LOOP⟧ Co-Authored-By: codex-refactor-loop fix r2 <noreply@aevatar>
🤖 Quality r2 review: approveTL;DR
详细说明本轮用 prompt 指定的三点 diff 复查，并打开了关键 touched files 的完整内容。新增的 r1 的可读性意见集中在 📎 完整 codex 原始输出(存档备查)---
pr: 744
role: quality
verdict: approve
---
## Verdict
Approve: the r2 diff is readable, focused on committed-state projection activation, and the prior large routing method has been split into clear actor-specific helpers.
## Evidence
- `src/platform/Aevatar.GAgentService.Projection/Orchestration/ServiceCommittedStateProjectionActivationPlanProvider.cs:21`: `GetPlans` is now a compact actor-type switch that delegates descriptor-specific logic to narrowly named helpers such as `DefinitionPlans`, `DeploymentPlans`, and `ServingSetPlans`; the earlier method-size/readability concern is resolved.
- `src/Aevatar.CQRS.Projection.Core/Orchestration/CommittedStateProjectionActivationHook.cs:14`: `CommittedStateProjectionActivationHook`, `IProjectionActivationPlanProvider`, `ProjectionActivationPlan`, and `ProjectionActivationPlanDispatcher` describe the committed-state activation responsibility directly and have multiple concrete provider callers registered in service, governance, and workflow projection modules, so this is not a dead or single-implementer abstraction smell.
- `src/Aevatar.Foundation.Core/GAgentBase.TState.cs:254`: the mandated `// Refactor (iter18/cluster-006):` Old/New block is present at the publication hook call site and reads as a concrete migration note, not a placeholder.
- `src/platform/Aevatar.GAgentService.Application/Services/ServiceCommandApplicationService.cs:133`, `src/platform/Aevatar.GAgentService.Governance.Application/Services/ServiceGovernanceCommandApplicationService.cs:96`, and `src/workflow/Aevatar.Workflow.Infrastructure/Runs/WorkflowRunActorPort.cs:69`: removed command-path projection activation is focused on the cluster intent; I did not find unrelated whitespace/typo cleanup or dead private members left behind.
## What would change your verdict (only if comment or reject)
N/A.
REVIEW_DONE:744:quality:approve
⟦AI:AUTO-LOOP⟧⟦AI:AUTO-LOOP⟧ |
🤖 架构评审通过：PR 744 未发现新增架构违规TL;DR
详细说明我按三点检查：一是 结论是未发现 blocking 架构问题。核心路径从 command/application service 中删除同步 📎 完整 codex 原始输出(存档备查)pr: 744
|
🤖 Tests review：拒绝，projection activation provider 分支仍缺测试TL;DR
详细说明阻塞点集中在 同类问题还在 governance/workflow provider：governance provider 接受 9 类事件 descriptor，但测试只走了 📎 完整 codex 原始输出(存档备查)pr: 744
|
📊 codex 进展 review-pr744-architect-r2 (⏳ 进行中; 已跑 7 min)
|
📊 codex 进展 review-pr744-quality-r2 (⏳ 进行中; 已跑 7 min)
|
📊 codex 进展 review-pr744-tests-r2 (⏳ 进行中; 已跑 7 min)
|
…mmitted-state-publication refactor: cluster-006 committed-state publication hook(replacing closed PR #744)
1 participant
Phase 9 r3 consensus:structural(#732)
committed-state publication hook 激活现有 projection scope,删除 command-path activation facade。
关联 #732
⟦AI:AUTO-LOOP⟧