-
Notifications
You must be signed in to change notification settings - Fork 113
Fix LetsEncrypt breakage following discontinued support for sending expiration notifications #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hello, i'm working on the same issue and just found your PR. Tested succesfully and is already working in production. Thanks! |
Happy to hear it was helpful! @bakkerpeter hope you see this and be willing to merge it. |
|
For anyone needing a fix right now until the maintainer merge this you can use the following: |
Temporary fix for afosto#76
temp fix following afosto#76
binsky08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- works and looks good, thanks for the pr
- nice to know: getContact() is not called within this lib -> no internal side effects
|
Thanks for providing a fix for that. Is there any expected timeframe when this will go into a new release? |
|
any news here? |
|
can we merge this ??? |
Let's Encrypt no longer supports sending expiration notifications with contact info. This PR fixes the error.
Ref:
https://letsencrypt.org/2025/01/22/ending-expiration-emails/
https://community.letsencrypt.org/t/support-ended-for-expiration-notification-emails/238173