Report per-prompt usage from cumulative token totals - #367
Draft
alancyao wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Codex emits both a cumulative total and usage for the latest completion. Publishing the latest completion undercounts ACP prompts containing multiple completions, while publishing the cumulative total directly would re-report historical prompts. Taking a category-by-category delta reports only the usage attributable to the current ACP prompt.
The transport cache stores one overwritten snapshot per thread. It captures restored usage emitted immediately after thread resume, before prompt-specific notification handling begins, and is cleared with the thread handlers.
API contract question
ACP Usage is described as token usage for a prompt turn, while its field documentation refers to totals across a session. This change follows the per-prompt interpretation for PromptResponse usage. Maintainer confirmation on that intent would be helpful.
Test Plan