Honor workspace-write sandbox config on every turn - #368
Open
Greg-Moskalenko wants to merge 3 commits into
Open
Conversation
Co-authored-by: Greg Moskalenko <greg1mosk@gmail.com> Signed-off-by: Greg Moskalenko <greg1mosk@gmail.com>
Greg-Moskalenko
marked this pull request as ready for review
August 5, 2026 21:31
Co-authored-by: Greg Moskalenko <greg1mosk@gmail.com> Signed-off-by: Greg Moskalenko <greg1mosk@gmail.com>
Co-authored-by: Greg Moskalenko <greg1mosk@gmail.com> Signed-off-by: Greg Moskalenko <greg1mosk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sandbox_workspace_write.network_access = truewhen codex-acp builds each workspace-write turn policysandbox_workspace_write.writable_rootsinto that same per-turn policy, with exact deduplicationWhy
codex-acp passes a mode-specific sandbox policy on every turn. The default Agent mode hardcodes
networkAccess: falseand an empty root list, so it overrides a caller's valid session-level workspace-write network and root configuration. A client can therefore create a correctly configured thread but receive turns that lack both its requested network access and isolated writable roots.This change carries only the explicit workspace-write settings into the per-turn workspace-write policy. It does not select danger-full-access, widen another mode, or alter the approval policy.
Validation
npm run typechecknpm test(38 files passed, 6 skipped; 349 tests passed, 28 skipped)npm run bundle:all(Linux x64/arm64, macOS x64/arm64, Windows x64/arm64)