fix: Event ordering#153
Merged
Merged
Conversation
Closes #143 TIL a lot about how events are queued due to "syntactic sugar" that has more effects than I thought! The change is able to get this test passing though!
Member
Author
|
@anvilpete sorry for the delay here, but thanks for the detailed writeup, was able to use it as a driving test for the fix. |
Contributor
|
Many thanks for the fix, and all your work on this project! That async/await behaviour was a surprise to me too, it's a shame that extra microtask hop is enough to break the event ordering. Hopefully the test is enough to prevent it from coming back in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
TIL a lot about how events are queued due to "syntactic sugar" that has
more effects than I thought!
The change is able to get this test passing though!