feat: fix feishu channel reload failed#1817
Merged
rayrayraykk merged 2 commits intoagentscope-ai:mainfrom Mar 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Feishu channel reload/shutdown stability by making the WebSocket client run on a per-thread event loop and adding cleanup/guards to avoid using a closed loop during reload.
Changes:
- Track a dedicated WebSocket thread event loop (
_ws_loop) and restorelark_oapi.ws.client.loopafter the thread exits. - Add a
_closedflag to drop incoming WS messages during shutdown. - Update
stop()to stop the WS event loop and add a warning when the WS thread does not terminate within the timeout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9 tasks
This was referenced Mar 19, 2026
9 tasks
hongxicheng
approved these changes
Mar 19, 2026
futuremeng
pushed a commit
to futuremeng/CoPaw
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this PR does and why]
Related Issue: Fixes #(issue_number) or Relates to #(issue_number)
Security Considerations: [If applicable, e.g. channel auth, env/config handling]
Type of Change
Component(s) Affected
Checklist
pre-commit run --all-fileslocally and it passespytestor as relevant) and they passTesting
[How to test these changes]
Local Verification Evidence
Additional Notes
[Optional: any other context]