Fix Tinker API#553
Merged
Merged
Conversation
Collaborator
Author
|
/unittest-module-common |
1 similar comment
Collaborator
Author
|
/unittest-module-common |
Summary
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
|
/unittest-module-common |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-pattern-TestTinkerAPI |
Summary
Github Test Reporter by CTRF 💚 |
chenyushuo
reviewed
May 26, 2026
chenyushuo
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the
samplemethod invllm_model.pyto ensure compatibility with the new tinker interfacesamplemethod invllm_model.pyto collect prompt log probabilities (prompt_logprobs) and top-k prompt log probabilities (topk_prompt_logprobs) as NumPy arrays instead of Python lists, improving performance and downstream compatibility. TheSampledSequenceandSampleResponsenow use NumPy arrays for token IDs and logprobs.TopkPromptLogprobstype for structured storage of top-k logprobs, and updated the method to returnprompt_logprobs_npandtopk_prompt_logprobs_npfields.Checklist
Please check the following items before code is ready to be reviewed.