Refactor Docker environment and unit test workflow#554
Merged
chenyushuo merged 3 commits intoMay 26, 2026
Conversation
chenyushuo
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a major refactor of the Trinity-RFT Docker-based test environment to improve maintainability, configurability, and usability for both local development and CI workflows. The changes include moving and renaming Docker-related files, introducing new helper scripts, improving environment configuration, and updating CI workflows to use the new structure. The Docker setup is now more modular, with clear documentation and machine-specific configuration, making it easier to run and debug tests in a consistent environment.
Docker environment restructuring and configuration:
scripts/docker/Dockerfile.uvtodocker/Dockerfile, and updated all references accordingly. [1] [2] [3]docker/env.exampleas a template for machine-specific Docker environment variables, and require users to copy it todocker/envbefore use. Updated the Docker Compose file to use these environment variables for GPU assignment, image name, mount points, and endpoints. [1] [2] [3]docker/README.mdexplaining hardware requirements, configuration, and usage of the new helper scripts for starting, checking, running tests, and stopping the environment.Helper scripts for Docker test workflow:
docker/directory:start.sh,status.sh,run.sh,stop.sh, and a sharedcommon.shfor environment loading and Docker Compose invocation. These scripts standardize and simplify starting the environment, running tests, checking Ray cluster health, and cleanup. [1] [2] [3] [4] [5]CI workflow updates:
.github/workflows/unittest.yamlto use the new Docker structure and helper scripts for environment preparation, test execution, status checking, and cleanup. Improved the logic for selecting test directories and running tests based on changed files or user input. [1] [2] [3].github/workflows/docker.yamlto use the new Dockerfile location.Improvements to Docker Compose and environment variables:
docker/docker-compose.yamlto use environment variables for all machine-specific settings, removed hardcoded values, and made the setup more flexible for different hardware environments.Documentation and usability:
These changes collectively make the Docker-based test environment more robust, portable, and user-friendly, both for CI and for local development.
Checklist
Please check the following items before code is ready to be reviewed.