add python-versioneer#32
Open
warner wants to merge 2 commits intoagl:masterfrom
Open
Conversation
Contributor
Author
|
Oh, also, Versioneer is py2/py3-compatible. I don't think curve25519-donna is entirely py3-clean yet (I'll run some tests), but this won't make the situation worse. |
Contributor
Author
|
Just tested it: curve25519-donna does seem to be py3-clean. OTOH, Versioneer is not py2.5-compatible, so this would break the outstanding pull-request that adds py2.5 compatibility. If you land this one, you should probably WONTFIX the other one, and vice versa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This installs versioneer-0.12 to manage versioning of the python binding. The old setup.py only gets the version right if you're building from a git checkout. Versioneer also handles building from a tarball produced by "setup.py sdist" or "git archive", including the tarballs automatically generated by github's "Releases" page.
This also makes
curve25519.__version__available to runtime code.