chore: sync upstream pingdotgg/t3code - #184
Merged
Merged
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly sync of new commits from
pingdotgg/t3code(3513fa04f..ecb35f758, 6 commits), cherry-picked because this fork squash-merges tomain.Synced commits
2fdc704bb7b928d548c69120f48462442667d359789edecb35f758Conflict resolution
Exactly one file conflicted —
docs/operations/ci.md(docs only; the rest of the range applied cleanly).Upstream pingdotgg#3990 only rewrote the first bullet (
bun run lint/typecheck/test→ the Vite+ task-runner commands). The fork had independently diverged on the other bullets, so the hunk collided.Resolution keeps the fork's description of the fork's real CI, and adopts upstream's corrected command names:
.github/workflows/ci.yml: it really does runvp check(lint + typecheck),vpr typecheck, andvp run test. The fork's old text saidvp run typecheck, which was stale.release.ymlhere builds Windowsx64only (windows_signing: true, mobile builds deprecated). The mobile-deprecated and Windows-signing bullets are fork-local and were preserved.Verification
vp run typecheck— passvp check— 0 errors (1 pre-existing lint warning inConnectionsSettings.tsx, untouched by this sync)vp test run— 657 files / 5737 tests passed, 7 skippedNo prod-code changes were needed; the fork's model routing is registry-driven.
🤖 Generated with Claude Code