feat: audience-scoped asset and filesystem guard (dseg slice 8) - #208
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57967c9b7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 180d36dadc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59f54c34ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e18f301a5f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 652644a06e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
1 participant
Summary:
same-origin-relay-v1on asset URL requests. New servers return a typedAssetClientUpgradeRequiredErrorto old clients instead of issuing an unbound private URL, while new clients still decode old-server results with no surface credential.Test evidence:
vp check(0 errors; one unrelated pre-existing sidebar warning)vp run typecheck(15/15 packages)vp test run(6,129 passed, 7 skipped; 682 passed files, 2 skipped files)vp run lint:mobile(passed; optional host Swift/Kotlin linters unavailable)Design doc: /home/adam/.openclaw/reports/data-segregation-design-2026-07-17.md (§4, §6 slice 8).
Sequencing note: this slice deliberately guards the filesystem/asset/VCS read handlers WITHOUT changing external reachability. The factory audience-ceiling allowlist still excludes these methods, and a regression test asserts they remain unreachable by factory
orchestration:readsessions. Making them reachable (with audience-scoped positive/negative tests and per-method disclosure) is the dedicated slice 9 follow-up, per the approved design ruling of 2026-07-18 (guarding handlers and changing reachability are different risk classes and are not bundled in one diff).Deliberately deferred
The Electron
persist:t3code-preview-*partition bind bridge is deliberately deferred to a follow-up slice. Today the app renderer's relay cookie is not present in that preview partition's separate cookie jar, so a private desktop preview load fails closed with a masking 404 and never receives an unbound private asset URL.The characterization test
characterizes desktop preview partition loads without a relay cookie as masked 404pins that fail-closed behavior. This PR does not add a desktop IPC bind operation.