Setup Content-Type to application/octet-stream by default#1124
Merged
asvetlov merged 8 commits intoaio-libs:masterfrom Aug 26, 2016
avamsi:patch-1
Merged
Setup Content-Type to application/octet-stream by default#1124asvetlov merged 8 commits intoaio-libs:masterfrom avamsi:patch-1
asvetlov merged 8 commits intoaio-libs:masterfrom
avamsi:patch-1
Conversation
Contributor
Author
|
@asvetlov Just saw the failing tests. Sorry about that. |
aiohttp/web_reqrep.py
Outdated
|
|
||
| if body is not None and text is not None: | ||
| raise ValueError("body and text are not allowed together.") | ||
| raise ValueError('body and text are not allowed together') |
Member
There was a problem hiding this comment.
Please use " for exception messages
Contributor
Author
There was a problem hiding this comment.
I thought the difference in quotes usage was due to different contributors. I'll change it back
Member
|
Please don't forget about:
|
Current coverage is 98.15% (diff: 100%)@@ master #1124 diff @@
==========================================
Files 28 28
Lines 6387 6391 +4
Methods 0 0
Messages 0 0
Branches 1073 1074 +1
==========================================
+ Hits 6269 6273 +4
Misses 63 63
Partials 55 55
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue number
#944
Checklist