remove Application dependency from UrlDispatcher

[fafhrd91]

I think UrlDispatcher should not depend on Application object.
Here is backward compatible change to remove this dependency.

@asvetlov

[fafhrd91]

we need to update docs and add deprecation warning to router.add_subapp

i think UrlDispatcher should be part of public api

[codecov-io]

Current coverage is 98.69% (diff: 58.06%)

Merging #1510 into master will decrease coverage by 0.17%

@@             master      #1510   diff @@
==========================================
  Files            30         30          
  Lines          6986       7070    +84   
  Methods           0          0          
  Messages          0          0          
  Branches       1163       1180    +17   
==========================================
+ Hits           6907       6978    +71   
- Misses           39         52    +13   
  Partials         40         40          

Powered by Codecov. Last update 6da8ae9...dc13304

[popravich]

"cannod" typo

[popravich]

...a-ha, copied from here — "cannod"

[fafhrd91]

good catch

[fafhrd91]

@asvetlov objections?

also what about UrlDispatcher as part of public api?

[asvetlov]

Hmm. I dislike router.add_subapp = _wrap_add_subbapp(self) -- looks like a hack.

Also I doubt if it will work with all possible router implementations.
Adding add_subapp to Application doesn't look reasonable -- we are adding a way to register sub applications only but not regular routes.

I suggest keeping the code as is.

[fafhrd91]

router.add_subapp just for backward compatibility until next release

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.