Accept an errors parameter for text decoding ClientResponses

[bmuller]

What do these changes do?

Users can now give a parameter specifying what should happen to decoding errors when asking for the text() from a ClientResponse. This is passed directly into the bytes() decode method.

The internet is full of websites that have incorrectly specified their character encoding or that have one or two characters on a page that are not encoded correctly. Right now, the aiohttp library just throws an exception when this happens - for a more resilient solution, users should be able to optionally provide an alternative error handling strategy for incorrectly encoded characters.

Are there changes in behavior for the user?

Nope - just a new optional parameter.

Related issue number

Nope.

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• Add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new entry to CHANGES.rst
  • Choose any open position to avoid merge conflicts with other PRs.
  • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

[codecov-io]

Current coverage is 98.91% (diff: 100%)

Merging #1542 into master will decrease coverage by 0.01%

@@             master      #1542   diff @@
==========================================
  Files            30         30          
  Lines          6995       6989     -6   
  Methods           0          0          
  Messages          0          0          
  Branches       1169       1162     -7   
==========================================
- Hits           6920       6913     -7   
  Misses           37         37          
- Partials         38         39     +1   

Powered by Codecov. Last update 275e3b7...1a4ae3c

[fafhrd91]

Could you add test for this change?

[bmuller]

@fafhrd91 sure - what would you like to be tested though? This is a pretty inconsequential change that just passes another optional parameter down to Python std lib call.

[fafhrd91]

test that errors param get passed to decode function, also could you use errors keyword argument for decode function.

[bmuller]

OK - let me know if there's anything else you need @fafhrd91

[fafhrd91]

great! thanks

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.