Avoid creating TimerContext when there is no timeout#1817
Avoid creating TimerContext when there is no timeout#1817fafhrd91 merged 1 commit intoaio-libs:masterfrom jcugat:timeout-timernoop
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
+ Coverage 97.18% 97.18% +<.01%
==========================================
Files 37 37
Lines 7467 7469 +2
Branches 1297 1298 +1
==========================================
+ Hits 7257 7259 +2
Misses 89 89
Partials 121 121
Continue to review full report at Codecov.
|
This will allow to use aiohttp with ioloops that don't implement asyncio.Task.current_task, like Tornado's couroutine runner. More info: #1180
|
I believe Tornado should fix its issue with asyncio compatibility instead of trying to invent workarounds with tornado in every async library. |
|
Yes, I agree than the best outcome would be to implement |
|
thanks |
|
I am implementing alternative event loop at the moment, and |
This will allow to use aiohttp with ioloops that don't implement
asyncio.Task.current_task, like Tornado's couroutine runner.
More info: #1180
What do these changes do?
This will allow to use aiohttp with ioloops that don't implement asyncio.Task.current_task, like Tornado's couroutine runner.
Are there changes in behavior for the user?
This will restore previous functionality that was available in v1.3.3, which was possible to run with Tornado when setting
timeout=None. This was lost in this refactor: 38360f9Related issue number
More information is available in the original issue: #1180
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.