Use functools.wraps when wrapping synchronous handlers#1953
Merged
asvetlov merged 1 commit intoaio-libs:masterfrom Jun 5, 2017
Merged
Use functools.wraps when wrapping synchronous handlers#1953asvetlov merged 1 commit intoaio-libs:masterfrom
asvetlov merged 1 commit intoaio-libs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1953 +/- ##
==========================================
+ Coverage 97.05% 97.05% +<.01%
==========================================
Files 37 37
Lines 7610 7612 +2
Branches 1328 1328
==========================================
+ Hits 7386 7388 +2
Misses 101 101
Partials 123 123
Continue to review full report at Codecov.
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
They change the code that wraps synchronous functions, using functools.wraps to ensure that aspects from the synchronous functions such as
__doc__are also available on the wrapper.This allows to use aiohttp-swagger with synchronous handlers.
Are there changes in behavior for the user?
When accessed from the app, synchronous route handlers will now include additional metadata that before only asynchronous handlers provided.
Checklist
Documentation reflects the changesIt’s a bug fix which should not affect the documentation.
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.