Adding proxy header to aiohttp requests#2001
Closed
dshoe1989 wants to merge 0 commit intoaio-libs:masterfrom
Closed
Adding proxy header to aiohttp requests#2001dshoe1989 wants to merge 0 commit intoaio-libs:masterfrom
dshoe1989 wants to merge 0 commit intoaio-libs:masterfrom
Conversation
asvetlov
requested changes
Jun 22, 2017
Member
asvetlov
left a comment
There was a problem hiding this comment.
Tests are required.
Perhaps tests/test_proxy_functional.py is the best place for them.
aiohttp/client.py
Outdated
|
|
||
| # Merge with default headers and transform to CIMultiDict | ||
| headers = self._prepare_headers(headers) | ||
| proxy_headers = self.__prepare_headers(proxy_headers) |
Contributor
|
I wanted to update the PR but I managed to break it XD The commit was cc045a5 (just in case) |
Contributor
|
I know what I did wrong but I lost access I can't update the repo. I just made another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This adds a new proxy_headers param to session.request(), propagates that to the ClientRequest class, and uses it to the connector's _create_proxy_connection method.
I'm new to this so suggestions on how to test/how to update the documentation and such would be appreciated. Thanks!
Are there changes in behavior for the user?
There should not be any behavior changes as this is purely a feature addition
Related issue number
#1561
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.