Implement the third example of the POST multipart encoded file of the documentation#274
Merged
asvetlov merged 2 commits intoaio-libs:masterfrom Feb 16, 2015
Merged
Conversation
Member
|
-1 |
…he documentation If i'm not mistaken, the third example given in the documentation (here)[http://aiohttp.readthedocs.org/en/v0.14.4/client.html#post-a-multipart-encoded-file] does not work: ``` >>> url = 'http://httpbin.org/post' >>> files = {'file': ('report.csv', ... 'some,data,to,send\nanother,row,to,send\n') ... } >>> yield from aiohttp.request('post', url, data=files) ``` would post nothing
8efec93 to
088458f
Compare
Contributor
Author
|
Ok, updated the commit to edit the docs instead. It's kind of misleading as-is… |
Member
|
Please fix pep8 errors (run "$ make test" command before pushing changes) |
Contributor
Author
|
The pep8 error is unrelated to this commit ; I've fixed it none the less |
asvetlov
added a commit
that referenced
this pull request
Feb 16, 2015
Implement the third example of the `POST multipart encoded file` of the documentation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If i'm not mistaken, the third example given in the documentation (here)[http://aiohttp.readthedocs.org/en/v0.14.4/client.html#post-a-multipart-encoded-file] is not implemented:
would post nothing