Setup uploaded filename if field value is binary and transfer encoding is not specified

[asvetlov]

I have stuck again with subtle bug in aiohttp file uploading.

On call:

with open(fname, 'rb') as f:
    body = f.read()
yield from request('POST', url, data={'name': body})

body is sent as textual url-encoded string, which is unexpected.

I guess to assume the binary field value which sent without Transfer-Encoding is file body, filename is the same as field name if not specified.

requests library does the same, BTW.

Patch is attached.

[kxepal]

-0

I worry that data param turns into heavy overloaded by underlying logic so it's hard to say what kind of request payload would be sent exact for the some provided arguments. Imagine, that you'd read body somewhere far away from actual request call.

May be, instead, make things more explicit? For instance, by specifying Content-Type header and then dispatch data encoding according their value? At least, you'll be sure that data will be send exact in the format you want without giving you any surprises.

[asvetlov]

We need either fix current behavior (for passing data={'name': b'content'}) or directly forbid it. I prefer the former.

+1 for adding more explicit API for data sending but we need fix the current behavior first anyway.

[kxepal]

Ah, ok with the fix then.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.